Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

[issue-#1389] add multisig tx support #1390

Merged
merged 6 commits into from
Oct 20, 2022
Merged

[issue-#1389] add multisig tx support #1390

merged 6 commits into from
Oct 20, 2022

Conversation

@GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Oct 19, 2022 •
edited
Loading

Closes: #1389

Description

Added required logic to support multi-signature transactions using ethsecp256k1.PubKey public keys

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 19, 2022 •
edited
Loading

Codecov Report

Merging #1390 (a527b05) into main (83e509b) will increase coverage by 0.03%.
The diff coverage is 73.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1390      +/-   ##
==========================================
+ Coverage   56.00%   56.04%   +0.03%     
==========================================
  Files         108      108              
  Lines       10049    10074      +25     
==========================================
+ Hits         5628     5646      +18     
- Misses       4140     4144       +4     
- Partials      281      284       +3
Impacted Files Coverage Δ
app/ante/ante.go 58.13% <73.33%> (+5.68%) ⬆️

@GAtom22 GAtom22 requested a review from facs95 October 19, 2022 17:08
@GAtom22 GAtom22 marked this pull request as ready for review October 19, 2022 17:50
@GAtom22 GAtom22 requested a review from a team as a code owner October 19, 2022 17:50
@GAtom22 GAtom22 requested review from Vvaradinov and removed request for a team October 19, 2022 17:50
facs95
facs95 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@facs95 facs95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @GAtom22 👏

@facs95 facs95 merged commit 3ab761b into main Oct 20, 2022
@facs95 facs95 deleted the GAtom22/multi-sig-tx-support branch October 20, 2022 00:05
yihuang pushed a commit to crypto-org-chain/ethermint that referenced this pull request Nov 2, 2022
Revert "[issue-evmos#1389] add multisig tx support (evmos#1390)"
d40c29c 
This reverts commit 3ab761b.
@danburck danburck mentioned this pull request Nov 30, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Vvaradinov Vvaradinov Awaiting requested review from Vvaradinov Vvaradinov is a code owner automatically assigned from evmos/core-engineering

1 more reviewer

@facs95 facs95 facs95 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Support for Multisig Transactions

2 participants

@GAtom22 @facs95