Thanks to visit codestin.com
Credit goes to github.com

Skip to content

disable copying of field collection#270

Merged
greole merged 1 commit intomainfrom
fix/field-collection-copy
Mar 14, 2025
Merged

disable copying of field collection#270
greole merged 1 commit intomainfrom
fix/field-collection-copy

Conversation

@MarcelKoch
Copy link
Collaborator

Motivation

This fixes the issue #206.

This PR makes the FieldCollection not copyable, so the return value from FieldCollection::instance has to be stored as a reference.

@MarcelKoch MarcelKoch requested a review from bevanwsjones March 5, 2025 12:52
@MarcelKoch MarcelKoch self-assigned this Mar 5, 2025
@github-actions
Copy link

github-actions bot commented Mar 5, 2025

Deployed test documentation to https://exasim-project.com/NeoFOAM/Build_PR_270

@greole greole added the ready-for-review Set this label to indicate that the PR is ready for review label Mar 5, 2025
Copy link
Contributor

@greole greole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@greole greole force-pushed the fix/field-collection-copy branch from 4354311 to c6f47ae Compare March 14, 2025 15:44
@greole greole merged commit 60f1c30 into main Mar 14, 2025
19 checks passed
@greole greole deleted the fix/field-collection-copy branch March 14, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Set this label to indicate that the PR is ready for review ready-to-merge skip-changelog

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Field Collection non-reference construction causes no field to be registered.

2 participants