Update fan control #2859
Open
Update fan control #2859
+193
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I have tried to upgrade fan control module and add some improvements.
Now it should do the following:
1. Pop up some modal in case of errors
2. Establish a connection to SMC if it is installed (previously, it didn't do that and needed to reinstall app and helper to make it work)
3. Allow min value to be 0 in manual mode
4. Removed restore from RAM in wake up. The logic is after a sleep, the system is cooled down and it can be used in autoamtic mode
5. Tried to add support for single fan and 3+ fans
All modifications are tested on local build using MacOS 26.2 and XCode 26.2.