Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(server): suggest time unit in errors#152

Merged
ezyang merged 1 commit intomainfrom
codex/suggest-correct-time-unit-for-errors
May 23, 2025
Merged

feat(server): suggest time unit in errors#152
ezyang merged 1 commit intomainfrom
codex/suggest-correct-time-unit-for-errors

Conversation

@ezyang
Copy link
Owner

@ezyang ezyang commented May 23, 2025

Summary

  • guess appropriate time unit when numeric timestamps cannot be parsed
  • surface suggestion in error response
  • test hinting of time unit

Testing

  • ruff check scubaduck/server.py tests/test_server_errors.py
  • pyright scubaduck/server.py tests/test_server_errors.py
  • pytest -q tests/test_server_errors.py::test_invalid_integer_time_value_suggests_unit
  • pytest -q

@ezyang ezyang merged commit b2bd0b9 into main May 23, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments