remove invalid test #4207
Open
remove invalid test #4207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 14, 2024 10:14
This test was passing `should-fail=true` rather than `should_fail=true`;
however it's not clear what this test was doing as earthly was passing
so changing the argument to `should_fail=true` then causes this test to
fail (since earthly was not failing).
There was also a `test-fails` target, which was never used anywhere.
Ironically this target was also passing, so it wasn't a matter of simply
changing
DO --pass-args +RUN_EARTHLY_ARGS --target=/the-test+test --should-fail=true
to
DO --pass-args +RUN_EARTHLY_ARGS --target=/the-test+test-fails --should_fail=true
Signed-off-by: Alex Couture-Beil <[email protected]>
This is very similar to 40f42e3 Signed-off-by: Alex Couture-Beil <[email protected]>
2cd3d88 to
306dc65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was passing
should-fail=truerather thanshould_fail=true; however it's not clear what this test was doing as earthly was passing so changing the argument toshould_fail=truethen causes this test to fail (since earthly was not failing).There was also a
test-failstarget, which was never used anywhere. Ironically this target was also passing, so it wasn't a matter of simply changingto