Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: move and rename MobileInputMode #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2025
Merged

chore: move and rename MobileInputMode #251

merged 2 commits into from
Apr 1, 2025

Conversation

@sofib
Copy link
Contributor

@sofib sofib commented Apr 1, 2025 •
edited
Loading

Currently jsUtil package is sourced under internal directory. This directory is protected and cannot be depended on by consumer projects.

This PR moves the type MobileInputMode under jsUtil package from internal to within public package utilities in order to make widget.TextInputOpts.MobileInputMode usable by consumer projects.

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mcarpenter622
mcarpenter622 requested changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@mcarpenter622 mcarpenter622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and good find with the internal problem! I would ask that you do this change a little differently if possible. Instead of moving everything into utilities, can you please create a Constants.go inside utilities. and move just the 3 consts in there instead? I don't think the rest of the stuff needs to be visible unless you can give me a good reason.

@sofib
Copy link
Contributor Author

sofib commented Apr 1, 2025

Thanks for the quick response @mcarpenter622

I have absolutely nothing against - perhaps move MobileInputMode (and constants) to utilities/mobile and rename to InputMode to avoid redundancy in naming and not have structure belonging to too broad scope under utilities?

@mcarpenter622
Copy link
Collaborator

mcarpenter622 commented Apr 1, 2025

That works for me. @sofib

@sofib sofib changed the title chore: move jsUtil package to public package to be dependable chore: move and rename MobileInputMode Apr 1, 2025
@sofib sofib requested a review from mcarpenter622 April 1, 2025 21:05
@mcarpenter622 mcarpenter622 merged commit 3a898ec into ebitenui:master Apr 1, 2025
1 check passed
@mcarpenter622
Copy link
Collaborator

mcarpenter622 commented Apr 1, 2025

Thanks again

@sofib sofib deleted the jsutil-move branch April 1, 2025 21:33
@mcarpenter622
Copy link
Collaborator

mcarpenter622 commented Apr 1, 2025

Just a heads up I had to make an additional commit. Looks like there was still an old reference hanging out:
edf853c

@sofib
Copy link
Contributor Author

sofib commented Apr 2, 2025

Sorry about that @mcarpenter622 it seems IDE tricked me. I ran linter but didn't include build tag so it didn't popup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcarpenter622 mcarpenter622 mcarpenter622 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sofib @CLAassistant @mcarpenter622