Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix URI::ToFilename return value for error handling case #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
igem0n wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix URI::ToFilename return value for error handling case #8

igem0n wants to merge 1 commit into from

Conversation

@igem0n
Copy link

@igem0n igem0n commented Dec 3, 2025

Fixes build when compiler refuses to cast 0 int literal to std::string

@igem0n
Fix URI::ToFilename return value for error handling case
ad40ef6 
Fixes build when compiler refuses to cast 0 int literal to std::string
@scenarnick
Copy link
Collaborator

scenarnick commented Dec 4, 2025

Can you please elaborate which compilers fail on this one? Might be helpful to find other, similar places in code.

@igem0n
Copy link
Author

igem0n commented Dec 4, 2025 •
edited
Loading

I think this happens because std23 is enabled.
From cppreference:

basic_string( std::nullptr_t ) = delete; (8) (since C++23)

CMAKE_GENERATOR_TOOLSET=v143
C++ Standard 23 with extensions OFF
Windows SDK version 10.0.26100.0 to target Windows 10.0.26200
The C compiler identification is MSVC 19.44.35221.0
The CXX compiler identification is MSVC 19.44.35221.0

@scenarnick
Copy link
Collaborator

scenarnick commented Dec 4, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@igem0n @scenarnick