Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Workbench viewer limit is setup for 'C/C++ Projects' view.#1181

Merged
jonahgraham merged 1 commit intoeclipse-cdt:mainfrom
raghucssit:viewer-limit-setup-cview
Jun 9, 2025
Merged

Workbench viewer limit is setup for 'C/C++ Projects' view.#1181
jonahgraham merged 1 commit intoeclipse-cdt:mainfrom
raghucssit:viewer-limit-setup-cview

Conversation

@raghucssit
Copy link
Contributor

C/C++ Projects view makes eclipse unresponsive if it has more than 70k files in a directory inside a cpp project. So we can set up viewr limit for the JFace viewer.

see #1180

@raghucssit
Copy link
Contributor Author

@jonahgraham Please check this fix.. This is similar to 'Package Explorer'. 'Package Explorer' has this viewer setup done from eclipse 4.30.. Working good so far. I assume it is a safe fix.

@jonahgraham
Copy link
Member

@raghucssit there is a warning on the new method call - quoted here:

	 * <strong>EXPERIMENTAL</strong>. This class or interface has been added as part
	 * of a work in progress. There is no guarantee that this API will work or that
	 * it will remain the same. Please do not use this API without consulting with
	 * the API development team.
	 * </p>
	 *

@jonahgraham
Copy link
Member

This change looks good to me, and the fact the API is experimentally marked isn't a big deal, we just need to reach out to Platform UI folk to make sure they know we are using it.

@iloveeclipse
Copy link
Contributor

This change looks good to me, and the fact the API is experimentally marked isn't a big deal, we just need to reach out to Platform UI folk to make sure they know we are using it.

@jonahgraham : Raghu and me were the original Platform UI team developed that code :)

And yes, good point, we should remove the warning, it is now not experimental anymore. We simply forget about that...

@raghucssit: please create PR that removes it.

@iloveeclipse
Copy link
Contributor

please create PR that removes it.

Fixed via eclipse-platform/eclipse.platform.ui#3026.

@jonahgraham : we are ready to merge now?

C/C++ Projects view makes eclipse unresponsive if it has more than 70k
files in a directory inside a cpp project. So we can set up viewr limit
for the JFace viewer.

see eclipse-cdt#1180
@jonahgraham jonahgraham force-pushed the viewer-limit-setup-cview branch from 26f459d to 9ed8d50 Compare June 9, 2025 19:32
@jonahgraham
Copy link
Member

Yes, I rebased it to pick up #1185 and it can be merged if the code cleanliness passes.

@jonahgraham jonahgraham merged commit 5b76b3e into eclipse-cdt:main Jun 9, 2025
4 checks passed
@iloveeclipse
Copy link
Contributor

Thanks for merge!
@jonahgraham : could you please assign #1180 to @raghucssit, set milestone and close?

@jonahgraham
Copy link
Member

Thanks @raghucssit for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants