Workbench viewer limit is setup for 'C/C++ Projects' view.#1181
Workbench viewer limit is setup for 'C/C++ Projects' view.#1181jonahgraham merged 1 commit intoeclipse-cdt:mainfrom
Conversation
|
@jonahgraham Please check this fix.. This is similar to 'Package Explorer'. 'Package Explorer' has this viewer setup done from eclipse 4.30.. Working good so far. I assume it is a safe fix. |
|
@raghucssit there is a warning on the new method call - quoted here: |
|
This change looks good to me, and the fact the API is experimentally marked isn't a big deal, we just need to reach out to Platform UI folk to make sure they know we are using it. |
@jonahgraham : Raghu and me were the original Platform UI team developed that code :) And yes, good point, we should remove the warning, it is now not experimental anymore. We simply forget about that... @raghucssit: please create PR that removes it. |
Fixed via eclipse-platform/eclipse.platform.ui#3026. @jonahgraham : we are ready to merge now? |
C/C++ Projects view makes eclipse unresponsive if it has more than 70k files in a directory inside a cpp project. So we can set up viewr limit for the JFace viewer. see eclipse-cdt#1180
26f459d to
9ed8d50
Compare
|
Yes, I rebased it to pick up #1185 and it can be merged if the code cleanliness passes. |
|
Thanks for merge! |
|
Thanks @raghucssit for the fix |
C/C++ Projects view makes eclipse unresponsive if it has more than 70k files in a directory inside a cpp project. So we can set up viewr limit for the JFace viewer.
see #1180