-
Notifications
You must be signed in to change notification settings - Fork 197
[CP #2365 > support/v6.0] [core] Process state structure #2366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
| * @brief Definition of process datatypes. | ||
| **/ | ||
|
|
||
| #include <string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'string' file not found [clang-diagnostic-error]
#include <string>
^|
|
||
| #include "ecal/process_severity.h" | ||
|
|
||
| namespace eCAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: variable 'eCAL' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
namespace eCAL
^|
|
||
| eCAL::Process::eSeverity g_process_severity(eCAL::Process::eSeverity::unknown); | ||
| eCAL::Process::eSeverityLevel g_process_severity_level(eCAL::Process::eSeverityLevel::level1); | ||
| Types::Process::SProcessState g_process_state; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: variable 'g_process_state' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
Types::Process::SProcessState g_process_state;
^| eCAL::Process::eSeverity g_process_severity(eCAL::Process::eSeverity::unknown); | ||
| eCAL::Process::eSeverityLevel g_process_severity_level(eCAL::Process::eSeverityLevel::level1); | ||
| Types::Process::SProcessState g_process_state; | ||
| std::mutex g_process_state_mutex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: variable 'g_process_state_mutex' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
std::mutex g_process_state_mutex;
^|
|
||
| extern eCAL::Process::eSeverity g_process_severity; | ||
| extern eCAL::Process::eSeverityLevel g_process_severity_level; | ||
| extern Types::Process::SProcessState g_process_state; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: variable 'g_process_state' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
extern Types::Process::SProcessState g_process_state;
^| extern eCAL::Process::eSeverity g_process_severity; | ||
| extern eCAL::Process::eSeverityLevel g_process_severity_level; | ||
| extern Types::Process::SProcessState g_process_state; | ||
| extern std::mutex g_process_state_mutex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: variable 'g_process_state_mutex' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
extern std::mutex g_process_state_mutex;
^
Cherry-pick
Cherry-picked PR #2365 to branch
support/v6.0.The cherry-pick was successful.
Please review the changes and rebase-merge if desired.