Fix default value handling during job step creation #4052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4052 +/- ##
=============================================
+ Coverage 16.67% 16.78% +0.11%
Complexity 22 22
=============================================
Files 2008 2006 -2
Lines 52134 52089 -45
Branches 4409 4384 -25
=============================================
+ Hits 8691 8745 +54
+ Misses 43041 42949 -92
+ Partials 402 395 -7
|
Coduz
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the issue where job step creation does not handle default values correctly. For example, when creating a job step with command execution, if only the
commandInputparameter is set and thetimeoutparameter is left as default, the submission would fail due to thetimeoutnot being set.Steps to Reproduce
commandInputparameter and leavingtimeoutas default.Current Behavior
On submission, there is an error due to the
timeoutnot being set.Expected Behavior
Job step creation should succeed. The
JobStepPropertiesinJobStepDefinitionwith apropertyValueshould be used as a default value for theJobStepPropertiesinJobStepCreatorthat haven’t been passed from the user.