Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoiding test antipattern in Kapua api #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2022
Merged

Avoiding test antipattern in Kapua api #3632

merged 1 commit into from
Oct 28, 2022

Conversation

@dseurotech
Copy link
Contributor

@dseurotech dseurotech commented Oct 20, 2022 •
edited
Loading

Refactoring to avoid test classes to extend Assert - part 5

Signed-off-by: dseurotech [email protected]

@dseurotech dseurotech marked this pull request as ready for review October 20, 2022 09:56
@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Merging #3632 (261f5e9) into develop (727c2c5) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3632      +/-   ##
=============================================
- Coverage      50.12%   50.12%   -0.01%     
  Complexity       259      259              
=============================================
  Files           1668     1668              
  Lines          31987    31987              
  Branches        2634     2634              
=============================================
- Hits           16034    16033       -1     
- Misses         15017    15022       +5     
+ Partials         936      932       -4
Impacted Files Coverage Δ
...egistry/event/internal/DeviceEventServiceImpl.java 67.27% <0.00%> (-5.46%) ⬇️
...a/service/device/registry/internal/DeviceImpl.java 61.90% <0.00%> (-0.69%) ⬇️
...pse/kapua/commons/service/internal/ServiceDAO.java 66.97% <0.00%> (+0.62%) ⬆️
...rtz/persistence/KapuaQuartzConnectionProvider.java 100.00% <0.00%> (+12.50%) ⬆️

@dseurotech dseurotech changed the title Test classes not longer extending Assert - part 5 Avoiding test antipattern in Kapua api Oct 21, 2022
@dseurotech dseurotech force-pushed the fix-doNotExtendAssert5 branch from cb8c296 to c901227 Compare October 21, 2022 07:38
@dseurotech
:fix: importing org.junit.Assert and explicitly referencing its metho…
261f5e9 
…ds instead of having test classes extend it

Signed-off-by: dseurotech <[email protected]>
@dseurotech dseurotech force-pushed the fix-doNotExtendAssert5 branch from c901227 to 261f5e9 Compare October 26, 2022 15:07
@Coduz Coduz added Enhancement This PR/Issue improves an part of Kapua Test Test related stuff. It's a dirty job, but someone needs to do that! labels Oct 28, 2022
@Coduz Coduz merged commit 5ff5119 into eclipse-kapua:develop Oct 28, 2022
@dseurotech dseurotech deleted the fix-doNotExtendAssert5 branch October 28, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Coduz Coduz Coduz approved these changes

Assignees

No one assigned

Labels

Enhancement This PR/Issue improves an part of Kapua Test Test related stuff. It's a dirty job, but someone needs to do that!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dseurotech @Coduz