Fixed Endpoint View permissions #3660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alberto Codutti <[email protected]>
…ame because they were misleading on their actual usage Signed-off-by: Alberto Codutti <[email protected]>
Signed-off-by: Alberto Codutti <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #3660 +/- ##
=============================================
- Coverage 48.03% 43.60% -4.44%
+ Complexity 259 184 -75
=============================================
Files 1686 1686
Lines 32165 32165
Branches 2642 2642
=============================================
- Hits 15452 14027 -1425
- Misses 15806 17332 +1526
+ Partials 907 806 -101
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the permission and checks required to show the Endpoint View on console which should be available only to admin account, and only if the selected account is the root account or one of the first level accounts.
Related Issue
This PR fixes changes made in #3560 which was wrong due to misleading
GwtSession.getRootAccountId()method.Description of the solution adopted
GwtSessionclassGwtSession.getRootAccountId()andGwtSession.getRootAccountName()Screenshots
None
Any side note on the changes made
None