Fixed permission checks for not-groupable domains #3678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3678 +/- ##
==============================================
- Coverage 54.72% 13.42% -41.31%
==============================================
Files 1821 1821
Lines 33766 33772 +6
Branches 2657 2657
==============================================
- Hits 18480 4534 -13946
- Misses 14312 28854 +14542
+ Partials 974 384 -590
|
42a0e63 to
b028e53
Compare
6bdfeed to
9348b88
Compare
Signed-off-by: Alberto Codutti <[email protected]>
9348b88 to
c9a36a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the permission checking when a permission is assigned to a group in a not-groupable Domain.
Is not possible to assign a "direct" permission on a group which is not groupable (e.g.
tag:read:1:{groupId}) but it is possible to assign a wildcard permission that then is checked againgst a not groupable domain (e.g.*:read:1:{groupId}.Related Issue
None
Description of the solution adopted
Added a check on the target permission Domain. If it is not groupable, this means that the user permission (e.g.
*:read:1:{groupId}) should be extended to all groups (e.g.*:read:1:*) only for not groupable domains.Screenshots
None
Any side note on the changes made
None