Fixed AccountService improper segregation #3670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3670 +/- ##
==============================================
- Coverage 43.91% 31.51% -12.40%
+ Complexity 184 120 -64
==============================================
Files 1686 1686
Lines 32168 32183 +15
Branches 2640 2642 +2
==============================================
- Hits 14127 10143 -3984
- Misses 17195 21556 +4361
+ Partials 846 484 -362
|
Signed-off-by: Alberto Codutti <[email protected]>
Signed-off-by: Alberto Codutti <[email protected]>
Signed-off-by: Alberto Codutti <[email protected]>
Signed-off-by: Alberto Codutti <[email protected]>
Signed-off-by: Alberto Codutti <[email protected]>
663e634 to
12af987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an improper segregation of scopes in AccountService.
Related Issue
None
Description of the solution adopted
Fixed the invocations of
AcccountService.find(...)to always performcheckAccessScreenshots
None
Any side note on the changes made
None