Improve handling and checking of values in Birth Message #3697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3697 +/- ##
============================================
- Coverage 41.75% 27.03% -14.72%
============================================
Files 1822 1822
Lines 33791 33948 +157
Branches 2663 2715 +52
============================================
- Hits 14109 9178 -4931
- Misses 18699 24044 +5345
+ Partials 983 726 -257
|
4156b5b to
88d73ca
Compare
6c30fe8 to
298cabc
Compare
8e2a6b4 to
c43d1c3
Compare
Signed-off-by: Alberto Codutti <[email protected]>
…le big values from connectied Device Signed-off-by: Alberto Codutti <[email protected]>
… SettingKeys Signed-off-by: Alberto Codutti <[email protected]>
Signed-off-by: Alberto Codutti <[email protected]>
…e.length.max' setting Signed-off-by: Alberto Codutti <[email protected]>
Signed-off-by: Alberto Codutti <[email protected]>
Signed-off-by: Alberto Codutti <[email protected]>
Signed-off-by: Alberto Codutti <[email protected]>
Signed-off-by: Alberto Codutti <[email protected]>
Signed-off-by: Alberto Codutti <[email protected]>
…ations Signed-off-by: Alberto Codutti <[email protected]>
Signed-off-by: Alberto Codutti <[email protected]>
c43d1c3 to
5b0646b
Compare
Signed-off-by: Alberto Codutti <[email protected]>
…moved not being backward compatible Signed-off-by: Alberto Codutti <[email protected]>
75c0b50 to
51c8d6e
Compare
.../src/main/java/org/eclipse/kapua/service/device/registry/KapuaDeviceRegistrySettingKeys.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alberto Codutti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of fields of the Birth Message which create/update the information of a device.
Main improvements are:
connectionInterfacedevice registry - device lifecycle test scenario may fail for some network configurations #1237connectionIpDevice registration error when connectionIp exceeds field size #2726Related Issue
This PR fixes #1237 and fixes #2726
Description of the solution adopted
DeviceCreator/Devicefields.connectionIpandconnectionInterfacesan "overflow" field has been created to handle big values.Screenshots
None
Any side note on the changes made
A bit of code cleanup and javadoc cleanup