Correct retrieval of specific endpoints #3727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etrieve endpoints
Codecov Report
@@ Coverage Diff @@
## develop #3727 +/- ##
=============================================
+ Coverage 55.47% 55.82% +0.35%
Complexity 8 8
=============================================
Files 1835 1835
Lines 34054 34060 +6
Branches 2721 2723 +2
=============================================
+ Hits 18890 19014 +124
+ Misses 14166 14049 -117
+ Partials 998 997 -1
|
Coduz
requested changes
Mar 1, 2023
...ernal/src/main/java/org/eclipse/kapua/service/endpoint/internal/EndpointInfoServiceImpl.java
Outdated
Show resolved
Hide resolved
...ernal/src/main/java/org/eclipse/kapua/service/endpoint/internal/EndpointInfoServiceImpl.java
Outdated
Show resolved
Hide resolved
Coduz
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR.
Modifications to the "find" function inside the endpoint service to correctly retrieve specific endpoints.
Description of the solution adopted
The query function of the service has been re-used in order to retrieve the available endpoints in the scope (aka, the nearest defined proceeding upwards in the hierarchy). This doesn't mean a performance penalty with respect to a specific traversal to retrieve the same data because actually the steps performed are the same.