Improved CredentialService.getMinimumPasswordLength to handle also ANY as scopeId #3757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardomodanese
approved these changes
Mar 30, 2023
Codecov Report
@@ Coverage Diff @@
## develop #3757 +/- ##
==============================================
- Coverage 50.04% 11.33% -38.71%
+ Complexity 26 6 -20
==============================================
Files 1864 1864
Lines 35264 35266 +2
Branches 2784 2785 +1
==============================================
- Hits 17649 3999 -13650
- Misses 16708 30925 +14217
+ Partials 907 342 -565
|
…Y as scopeId Signed-off-by: Alberto Codutti <[email protected]>
7a1e5eb to
c56055f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the implementation of
CredentialService.getMinimumPasswordLengthto allow to specifyscopeIdto beKapuaId.ANYand get the system minimum length passowrd allowed.Related Issue
None
Description of the solution adopted
Added the managing of
KapuaId.ANYand other checks.Screenshots
None
Any side note on the changes made
None