Fix - Updated CORS filtering logic to remove false positives #3750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3750 +/- ##
=============================================
+ Coverage 55.78% 55.81% +0.03%
Complexity 8 8
=============================================
Files 1835 1835
Lines 34138 34145 +7
Branches 2726 2729 +3
=============================================
+ Hits 19043 19059 +16
Misses 14093 14093
+ Partials 1002 993 -9
|
Coduz
requested changes
Mar 23, 2023
...ns-rest/filters/src/main/java/org/eclipse/kapua/commons/rest/filters/CORSResponseFilter.java
Outdated
Show resolved
Hide resolved
...ns-rest/filters/src/main/java/org/eclipse/kapua/commons/rest/filters/CORSResponseFilter.java
Outdated
Show resolved
Hide resolved
...ns-rest/filters/src/main/java/org/eclipse/kapua/commons/rest/filters/CORSResponseFilter.java
Outdated
Show resolved
Hide resolved
...ns-rest/filters/src/main/java/org/eclipse/kapua/commons/rest/filters/CORSResponseFilter.java
Outdated
Show resolved
Hide resolved
...ns-rest/filters/src/main/java/org/eclipse/kapua/commons/rest/filters/CORSResponseFilter.java
Outdated
Show resolved
Hide resolved
...ns-rest/filters/src/main/java/org/eclipse/kapua/commons/rest/filters/CORSResponseFilter.java
Outdated
Show resolved
Hide resolved
Coduz
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CORS filtering logic is revisited in order to remove false positives for requests coming from the same origin. The code adapts, with the best effort, to browsers not compatible with the sec-fetch-site header. In fact, in this case, the cors filtering is performed but logically it is impossible to prevent false positives.