Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Agnul97
Copy link
Contributor

@Agnul97 Agnul97 commented May 30, 2023

On Kapua, other than images tagged as the latest and with the version number, a set of images tagged with the current timestamp is created during the build. If this feature could be useful in some contexts, where for example daily builds are performed and you need to save a temporal snapshot of images, this is needless in our context and, mainly, creates overhead because for each different timestamp (currently it has a granularity of 1 day) a new image is created which occupies memory on disk, resulting in a prune of images after some time to save disk space if the building is repeated over time.

This PR removes the timestamped tagged images being built.

@Coduz Coduz added Bug This is a bug or an unexpected behaviour. Fix it! build labels May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #3784 (b33bd07) into develop (fd877d7) will increase coverage by 2.26%.
The diff coverage is 32.50%.

❗ Current head b33bd07 differs from pull request most recent head bd8a409. Consider uploading reports for the commit bd8a409 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3784      +/-   ##
=============================================
+ Coverage      49.19%   51.45%   +2.26%     
  Complexity        26       26              
=============================================
  Files           1865     1866       +1     
  Lines          35275    35284       +9     
  Branches        2786     2782       -4     
=============================================
+ Hits           17352    18155     +803     
+ Misses         17003    16176     -827     
- Partials         920      953      +33     
Impacted Files Coverage Δ
...pse/kapua/job/engine/commons/logger/JobLogger.java 0.00% <0.00%> (ø)
...resources/v1/resources/UserCredentialFiltered.java 0.00% <0.00%> (ø)
...ice/endpoint/internal/EndpointInfoServiceImpl.java 82.25% <86.66%> (+1.96%) ⬆️

... and 169 files with indirect coverage changes

@Coduz Coduz merged commit 4270dbe into eclipse-kapua:develop May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug This is a bug or an unexpected behaviour. Fix it! build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants