FIX - Foreign keys liquibase scripts correctly imported and executed #3884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scripts on containers
Codecov Report
@@ Coverage Diff @@
## develop #3884 +/- ##
==========================================
Coverage 20.58% 20.58%
Complexity 6 6
==========================================
Files 1936 1936
Lines 41534 41534
Branches 3945 3945
==========================================
Hits 8549 8549
Misses 32588 32588
Partials 397 397 |
05e9120 to
f600bbb
Compare
Coduz
approved these changes
Oct 30, 2023
Coduz
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR.
I noticed that there were a problems in the project related to the liquibase scripts for the foreign keys (namely, the ones inside the "extra" module):
The way of including those liquibase scripts through the configuration of the assembly descriptors:
was wrong because, in order to have in the final container the scripts to run, the right "output directory" should be var/opt/jetty/webapps/root/WEB-INF/lib (the classpath) and not the one present on the screen. This wrong configuration led to the missing of FKs liquibase scripts in some containers (for example, the rest-API container)
Description of the solution adopted
For some containers, for example, the console, the FK scripts were imported not through the configuration of the XML descriptor but with a dependency on the FK module, included inside the POM file of the "web application" module, like this:
To solve the problem, I decided to uniform this way of importing the scripts in the other containers...also, I think that this is the simpler way to include in the classpath the scripts