FIX - Function "convertToDataIndexes" throwing error when one bad format index is present #3981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3981 +/- ##
=============================================
+ Coverage 21.09% 21.19% +0.09%
Complexity 10 10
=============================================
Files 1942 1942
Lines 41252 41263 +11
Branches 3793 3796 +3
=============================================
+ Hits 8702 8745 +43
+ Misses 32143 32114 -29
+ Partials 407 404 -3
|
added 4 commits
March 1, 2024 12:14
…DataIndexes" returned list of indexes contains only indexes with a valid format
…erent time windows
0f3103a to
4d7bc77
Compare
Coduz
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR.
The method DatastoreUtils::convertToDataIndexes, if called passing at least 1 index with a bad format (for example, 1-data-message-2024-23-07-17_migrated), was throwing an exception. In this PR the behavior of the function is changed to still return a list, but with those indexes with a wrong format excluded from it. This holds also when both the time windows in input are null.
This change could be useful if one calls the function when, for example, wants to perform a clean-up of expired data indexes
Furthermore, a set of tests have been added to verify the behavior of the new method
Any side note on the changes made
The method was not conforming to an interface so no side effects should be present