Thanks to visit codestin.com
Credit goes to github.com

Skip to content

import: import log crate as baseline #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

import: import log crate as baseline #18

wants to merge 2 commits into from

Conversation

@pawelrutkaq
Copy link
Contributor

@pawelrutkaq pawelrutkaq commented Sep 16, 2025 •
edited
Loading

Import from log crate 3aa1359e926a39f841791207d6e57e00da3e68e2 at https://github.com/rust-lang/log

This is as follow up to decision in CFG Logging: eclipse-score/inc_mw_log#6 (comment)
to enable Rust code with common frontend.

Please consider that this is only enabler (eclipse-score/inc_mw_log#5), and frontend will be done from scratch in S-CORE (however it will be macro compatible). The Rust binding to C++ mw::log will be located in new logging repo.

@pawelrutkaq pawelrutkaq force-pushed the pawelrutkaq_rust_log_frontend branch 4 times, most recently from 9fb527d to ae050e3 Compare September 16, 2025 11:53
@pawelrutkaq
Copy link
Contributor Author

@hoppe-and-dreams @rmaddikery @arsibo The frontend was moved as requested. (FYI: @darkwisebear )

FScholPer
FScholPer requested changes Sep 24, 2025
View reviewed changes
Copy link

@FScholPer FScholPer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please first request the upstream to change if that doesn't work we should to a real fork in a separate repository.

@pawelrutkaq
Copy link
Contributor Author

Can you please first request the upstream to change if that doesn't work we should to a real fork in a separate repository.
Not sure what does not work ?:)

rmaddikery
rmaddikery reviewed Oct 14, 2025
View reviewed changes
Copy link

@rmaddikery rmaddikery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the repo does not have all the checks in place please add in description if you follow Rust's naming convention and coding guidelines? E.g.: https://github.com/rust-lang/style-team/blob/master/guide/guide.md

I see few unit tests, but not covered for all. Is this planned?
https://doc.rust-lang.org/rust-by-example/testing.html

@pawelrutkaq
Copy link
Contributor Author

Follow ups plannned after this PR:
eclipse-score/score#1896
eclipse-score/score#1897

For "imported" code, this is as is. As in above, this going to be fixed in MVP

rmaddikery
rmaddikery reviewed Oct 14, 2025
View reviewed changes
Copy link

@rmaddikery rmaddikery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A readme can be useful that demonstrates the usage and assumptions of use

@pawelrutkaq
Copy link
Contributor Author

Since the repo does not have all the checks in place please add in description if you follow Rust's naming convention and coding guidelines? E.g.: https://github.com/rust-lang/style-team/blob/master/guide/guide.md

I see few unit tests, but not covered for all. Is this planned? https://doc.rust-lang.org/rust-by-example/testing.html

As this is enabler from open source, no UT planned for this code. Only for new MVP providing proper frontend.

rmaddikery
rmaddikery reviewed Oct 14, 2025
View reviewed changes
score/mw/log/rust/Cargo.toml Outdated
name = "mw_log"
version = "0.0.1"
authors = ["S-CORE"]
readme = "README.md"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IS this missing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@johannes-esr johannes-esr mentioned this pull request Oct 14, 2025
Open
@pawelrutkaq
Copy link
Contributor Author

Since the repo does not have all the checks in place please add in description if you follow Rust's naming convention and coding guidelines? E.g.: https://github.com/rust-lang/style-team/blob/master/guide/guide.md

I see few unit tests, but not covered for all. Is this planned? https://doc.rust-lang.org/rust-by-example/testing.html

Quality and naming output:
pawel@pawel-VirtualBox ~/qorix/repos/baselibs/score/mw/log/rust (pawelrutkaq_rust_log_frontend) $ cargo clippy
Checking mw_log v0.0.1 (/home/pawel/qorix/repos/baselibs/score/mw/log/rust)
Finished dev profile [unoptimized + debuginfo] target(s) in 0.15s

pawel@pawel-VirtualBox ~/qorix/repos/baselibs/score/mw/log/rust (pawelrutkaq_rust_log_frontend) $ cargo build
Compiling mw_log v0.0.1 (/home/pawel/qorix/repos/baselibs/score/mw/log/rust)
Finished dev profile [unoptimized + debuginfo] target(s) in 0.11s

So common pratices for Rust followed.

@pawelrutkaq pawelrutkaq force-pushed the pawelrutkaq_rust_log_frontend branch 3 times, most recently from ff6f931 to e173ade Compare October 15, 2025 07:43
@pawelrutkaq pawelrutkaq requested a review from FScholPer October 16, 2025 10:44
@mishu-dev mishu-dev requested a review from 4og October 22, 2025 11:19
@pawelrutkaq pawelrutkaq force-pushed the pawelrutkaq_rust_log_frontend branch 3 times, most recently from 1d089e7 to 1278fde Compare October 23, 2025 09:41
@pawelrutkaq
import: import log crate as baseline
15066ff 
Import from log crate 3aa1359e926a39f841791207d6e57e00da3e68e2
at https://github.com/rust-lang/log

Signed-off-by: Pawel Rutka <[email protected]>
@pawelrutkaq pawelrutkaq force-pushed the pawelrutkaq_rust_log_frontend branch 2 times, most recently from 2ebf0a2 to 9d154b6 Compare October 23, 2025 09:55
@pawelrutkaq
Copy link
Contributor Author

@darkwisebear @4og @arsibo This is now done the way we agreed on (https://github.com/orgs/eclipse-score/discussions/236#discussioncomment-14759725). Can we have last look and continue ?

@pawelrutkaq pawelrutkaq force-pushed the pawelrutkaq_rust_log_frontend branch from 9d154b6 to 758617f Compare October 23, 2025 11:59
@pawelrutkaq
Copy link
Contributor Author

Managed to release score-crates so updated deps.

@4og
Copy link
Member

4og commented Oct 23, 2025

Hi @pawelrutkaq, your change is merged in 8e017e0 and 64924b7. Thank you for contribution!

@4og 4og closed this Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@castler castler Awaiting requested review from castler castler is a code owner

@hoe-jo hoe-jo Awaiting requested review from hoe-jo hoe-jo is a code owner

@LittleHuba LittleHuba Awaiting requested review from LittleHuba LittleHuba is a code owner

@ramceb ramceb Awaiting requested review from ramceb ramceb is a code owner

@hoppe-and-dreams hoppe-and-dreams Awaiting requested review from hoppe-and-dreams

@arsibo arsibo Awaiting requested review from arsibo

@nradakovic nradakovic Awaiting requested review from nradakovic nradakovic is a code owner

@rmaddikery rmaddikery Awaiting requested review from rmaddikery

@FScholPer FScholPer Awaiting requested review from FScholPer

@4og 4og Awaiting requested review from 4og

1 more reviewer

@darkwisebear darkwisebear darkwisebear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Logging FT
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pawelrutkaq @4og @darkwisebear @rmaddikery @FScholPer