Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@antonkri
Copy link
Contributor

No description provided.

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@antonkri antonkri mentioned this pull request Sep 10, 2025
@antonkri antonkri changed the title Ankr feature team creation Feature team creation Sep 10, 2025
@antonkri
Copy link
Contributor Author

Follow-up of #1281 with fixed findings.

Merge rights & code ownership
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
As already stated, every *Feature Team* has normally a dedicated repository. Before the creation of the new repository,
*Technical Leads* should initially nominate developers, whose review is mandatory for merging PRs to the repository
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Technical Leads* should initially nominate developers, whose review is mandatory for merging PRs to the repository
*Technical Leads* should nominate initial codeowners, whose review is mandatory for merging PRs to the repository

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

* GitHub Team for quality managers
* GitHub Team for safety managers

**ToDo**: can we have an 'AND relationship' for teams in CODEOWNERS file?
Copy link
Member

@AlexanderLanin AlexanderLanin Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. But we can create custom logic to enforce such rules. That's a custom CODEOWNER-like-solution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah exactly something like that. I don't know whether zephyr has the best solution for that or not. But from a concept point of view, it looks like a match.

Comment on lines +193 to +194
All other Technical Leads who are already committers in the S-CORE project are expected to support these
elections by voting positively, provided there are no specific objections.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates eclipse handbook.

Becoming a Committer is a privilege that is earned by contributing and showing discipline and good judgment. It is a responsibility that should be neither given nor taken lightly, nor is it a right based on employment by an Eclipse member company or any company employing existing Committers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was discussed and agreed with Wayne Beaton

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what was agreed is that if there are developer which are already in the historie because they did the job inhouse. For the rest I would agree that we need some kind of process which fits with the handbook

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FScholPer I think, we should apply here the same rules, that are applied when a new eclipse project is added and we add initial committers or project leads to it. I do not remember, that for s-core project we had to show any historie.....

@antonkri antonkri force-pushed the ankr_feature_team_creation branch from cc9d3c6 to 80de758 Compare September 10, 2025 11:22
Copy link
Contributor

@FScholPer FScholPer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until the role of the TLs and PLs with respect to the handbook of Eclipse is clear we can not continue

Afterwards a GitHub Issue is created in the `Technical Lead Cirle LOP project <https://github.com/orgs/eclipse-score/projects/3>`_
using the special *Feature Team Creation* GitHub Issue template and is assigned to one of the Technical Leads.

**ToDo**: create such a template.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a issue that we need additional work here


* **Developer GitHub Team**

Every *Feature Team* should have a corresponding software developer GitHub team, e.g. *ipc_ft_dev*, that contains all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a process how we can get the Teams?

Comment on lines +193 to +194
All other Technical Leads who are already committers in the S-CORE project are expected to support these
elections by voting positively, provided there are no specific objections.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what was agreed is that if there are developer which are already in the historie because they did the job inhouse. For the rest I would agree that we need some kind of process which fits with the handbook

@antonkri
Copy link
Contributor Author

Until the role of the TLs and PLs with respect to the handbook of Eclipse is clear we can not continue

@FScholPer could you please take care of the clarification?

@FScholPer
Copy link
Contributor

For me it would also be okay when we merge that version and if there is a change because of the discussion right now we do a change

FScholPer
FScholPer previously approved these changes Sep 11, 2025
Copy link
Contributor

@FScholPer FScholPer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment and as first version its okay

*Feature Teams* have end-to-end responsibility for specific functionalities. This includes all
aspects beginning with the architecture definition to the integration test. They are usually assigned
to the *S-CORE* main integration project or to one particular software module. *Feature Teams* work
independently of each other on *GitHub Issues* in the assigned software module.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call it work packages instad of GitHub issues to be more general?

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

⚠️ Docs-as-Code version mismatch detected
Please check the CI build logs for details and align the documentation version with the Bazel dependency.

Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for me

@antonkri antonkri merged commit b6c8f75 into main Oct 8, 2025
8 checks passed
@antonkri antonkri deleted the ankr_feature_team_creation branch October 8, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants