-
Notifications
You must be signed in to change notification settings - Fork 64
Feature team creation #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature team creation #1714
Conversation
|
The created documentation from the pull request is available at: docu-html |
|
Follow-up of #1281 with fixed findings. |
| Merge rights & code ownership | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| As already stated, every *Feature Team* has normally a dedicated repository. Before the creation of the new repository, | ||
| *Technical Leads* should initially nominate developers, whose review is mandatory for merging PRs to the repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| *Technical Leads* should initially nominate developers, whose review is mandatory for merging PRs to the repository | |
| *Technical Leads* should nominate initial codeowners, whose review is mandatory for merging PRs to the repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
| * GitHub Team for quality managers | ||
| * GitHub Team for safety managers | ||
|
|
||
| **ToDo**: can we have an 'AND relationship' for teams in CODEOWNERS file? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. But we can create custom logic to enforce such rules. That's a custom CODEOWNER-like-solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexanderLanin, did you have a look into the solution from Zephyr? https://github.com/zephyrproject-rtos/zephyr/blob/main/MAINTAINERS.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah exactly something like that. I don't know whether zephyr has the best solution for that or not. But from a concept point of view, it looks like a match.
| All other Technical Leads who are already committers in the S-CORE project are expected to support these | ||
| elections by voting positively, provided there are no specific objections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This violates eclipse handbook.
Becoming a Committer is a privilege that is earned by contributing and showing discipline and good judgment. It is a responsibility that should be neither given nor taken lightly, nor is it a right based on employment by an Eclipse member company or any company employing existing Committers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was discussed and agreed with Wayne Beaton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what was agreed is that if there are developer which are already in the historie because they did the job inhouse. For the rest I would agree that we need some kind of process which fits with the handbook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FScholPer I think, we should apply here the same rules, that are applied when a new eclipse project is added and we add initial committers or project leads to it. I do not remember, that for s-core project we had to show any historie.....
cc9d3c6 to
80de758
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until the role of the TLs and PLs with respect to the handbook of Eclipse is clear we can not continue
| Afterwards a GitHub Issue is created in the `Technical Lead Cirle LOP project <https://github.com/orgs/eclipse-score/projects/3>`_ | ||
| using the special *Feature Team Creation* GitHub Issue template and is assigned to one of the Technical Leads. | ||
|
|
||
| **ToDo**: create such a template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a issue that we need additional work here
|
|
||
| * **Developer GitHub Team** | ||
|
|
||
| Every *Feature Team* should have a corresponding software developer GitHub team, e.g. *ipc_ft_dev*, that contains all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a process how we can get the Teams?
| All other Technical Leads who are already committers in the S-CORE project are expected to support these | ||
| elections by voting positively, provided there are no specific objections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what was agreed is that if there are developer which are already in the historie because they did the job inhouse. For the rest I would agree that we need some kind of process which fits with the handbook
@FScholPer could you please take care of the clarification? |
|
For me it would also be okay when we merge that version and if there is a change because of the discussion right now we do a change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the moment and as first version its okay
| *Feature Teams* have end-to-end responsibility for specific functionalities. This includes all | ||
| aspects beginning with the architecture definition to the integration test. They are usually assigned | ||
| to the *S-CORE* main integration project or to one particular software module. *Feature Teams* work | ||
| independently of each other on *GitHub Issues* in the assigned software module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call it work packages instad of GitHub issues to be more general?
80de758 to
90e2538
Compare
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine for me
No description provided.