remove feature and target projects + add app and folder name #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planger
approved these changes
Dec 27, 2023
Collaborator
planger
left a comment
There was a problem hiding this comment.
Thank you very much, looks good to me! 👍
planger
added a commit
that referenced
this pull request
Dec 27, 2023
planger
added a commit
that referenced
this pull request
Dec 27, 2023
planger
added a commit
that referenced
this pull request
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced project structure complexity:
removed the
com.eclipsesource.megit.targetproject: it contained only one useful file-> moved the
com.eclipsesource.megit.target.targetfile tocom.eclipsesource.megit.parent/megit.targetremoved the
com.eclipsesource.megit.product.featureproject: it only included one plugin-> the
com.eclipsesource.megit.pluginplugin is now direcly included into the productchanged the way the app is packaged:
MeGitdirectory, this is easier when unzipping/untaring the appmegit-<unqualified version>-> to revert, remove the
rootFolderandarchiveFileNametags under configuration.products.product incom.eclipsesource.megit.product/pom.xml-> this will cause your github actions to not work correctly as the bundles are no more named like
"com.eclipsesource.megit-linux.gtk.x86_64.tar.gz"but"megit-0.5.0-linux.gtk.x86_64.tar.gz"