Metk 146 modifiers #125
Open
Metk 146 modifiers #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #125 +/- ##
===========================================
+ Coverage 70.12% 70.21% +0.09%
===========================================
Files 135 135
Lines 8143 8131 -12
Branches 780 781 +1
===========================================
- Hits 5710 5709 -1
+ Misses 2433 2422 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tbkr
requested changes
Oct 23, 2025
|
|
||
| T = """- context:\n type: [ofb,mfb,oai,sfb,fsoifb,fcdfb,ofa]\n obsgroup: [%(OBSGROUP)s]\n defaults:\n reportype: [%(REPORTYPE_LIST)s]\n""" | ||
|
|
||
| connectionDetails = dict(host = "webapps-db-prod", user = "ecmwf_ro", passwd = "ecmwf_ro") |
There was a problem hiding this comment.
I guess this shouldn't be in the public part of the repo?
| unset: [levtype, levelist, param, grid, rotation] | ||
|
|
||
| # new default for levtype=ml, to be enabled later | ||
| # - context: |
There was a problem hiding this comment.
Can we activate this already? I just recently stumbled across this behavior.
| connection.close() | ||
| return r | ||
|
|
||
| def getGroups(cursor): |
There was a problem hiding this comment.
There is a redefinition of the same method in line 34. Could we rename one of them, as they have different purposes.
…into METK-146_modifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
extracted all the mars request modifiers from the language file
added Python script to generate reportype modifiers
simplified context syntax
Contributor Declaration
By opening this pull request, I affirm the following: