Fix loop bounds for gcc+OpenMP compiler #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdeconinck
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Thanks for the very descriptive comment.
This looks good!
For mental verification when idx_t = int
max = std::numeric_limits<int>::max() = 2147483647
min = std::numeric_limits<int>::min() = -2147483648
j_end_ = max_over_two = 1073741823
j_begin_ = -max_over_two = -1073741823
j_end_ - j_begin_ = -2147483646 // greater than min so no overflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates initialization of loop bounds in
StructuredColumns_setupto avoid a miscompilation by gcc+OpenMP as described in #323Contributor Declaration
By opening this pull request, I affirm the following: