Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mpvginde
Copy link
Contributor

Description

This PR introduces a filter for converting specific humidity to dewpoint temperature or relative humidity at specific height (e.g. 2 metre) levels

What problem does this change solve?

What issue or task does this change relate to?

One of the filters that needed migrating from anemoi-datasets #92

Additional notes

This PR replaces the out of sync PR #99
Please check #99 for the original review comments

As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/

By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.

mpvginde and others added 20 commits July 23, 2025 11:47
## Description
<!-- What issue or task does this change relate to? -->

## What problem does this change solve?
<!-- Describe if it's a bugfix, new feature, doc update, or breaking
change -->

## What issue or task does this change relate to?
<!-- link to Issue Number -->

##  Additional notes ##
<!-- Include any additional information, caveats, or considerations that
the reviewer should be aware of. -->

***As a contributor to the Anemoi framework, please ensure that your
changes include unit tests, updates to any affected dependencies and
documentation, and have been tested in a parallel setting (i.e., with
multiple GPUs). As a reviewer, you are also responsible for verifying
these aspects and requesting changes if they are not adequately
addressed. For guidelines about those please refer to
https://anemoi.readthedocs.io/en/latest/***

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
<!-- What issue or task does this change relate to? -->

<!-- Describe if it's a bugfix, new feature, doc update, or breaking
change -->

<!-- link to Issue Number -->

<!-- Include any additional information, caveats, or considerations that
the reviewer should be aware of. -->

***As a contributor to the Anemoi framework, please ensure that your
changes include unit tests, updates to any affected dependencies and
documentation, and have been tested in a parallel setting (i.e., with
multiple GPUs). As a reviewer, you are also responsible for verifying
these aspects and requesting changes if they are not adequately
addressed. For guidelines about those please refer to
https://anemoi.readthedocs.io/en/latest/***

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@mpvginde mpvginde requested a review from a team as a code owner July 30, 2025 13:50
@github-project-automation github-project-automation bot moved this to Now In Progress in Anemoi-dev Jul 30, 2025
@github-actions github-actions bot added enhancement New feature or request dependencies Pull requests that update a dependency file tests and removed enhancement New feature or request labels Jul 30, 2025
Copy link
Contributor

@aaron-hopkinson aaron-hopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this together. It looks good, but I have a few minor comments, and some places where I think we can remove some of the duplication in the filters

@github-project-automation github-project-automation bot moved this from Now In Progress to Under Review in Anemoi-dev Jul 31, 2025
Copy link
Contributor

@aaron-hopkinson aaron-hopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking the time to do this!

@aaron-hopkinson aaron-hopkinson merged commit c28fd07 into main Aug 8, 2025
69 checks passed
@aaron-hopkinson aaron-hopkinson deleted the feat/thermo_conversions_height-clean branch August 8, 2025 15:28
@github-project-automation github-project-automation bot moved this from Under Review to Done in Anemoi-dev Aug 8, 2025
HCookie pushed a commit that referenced this pull request Oct 3, 2025
🤖 Automated Release PR

This PR was created by `release-please` to prepare the next release.
Once merged:

1. A new version tag will be created
2. A GitHub release will be published
3. The changelog will be updated

Changes to be included in the next release:
---


##
[0.1.17](0.1.16...0.1.17)
(2025-10-01)


### Features

* Add lsnp to sp filter
([#163](#163))
([7c19393](7c19393))
* Add methods to MD() in field wrapper
([#173](#173))
([c564459](c564459))
* Control returned inputs in filters
([#100](#100))
([32cb937](32cb937))
* **filters:** Add filter for thermodynamic conversions at specific
height levels
([#140](#140))
([c28fd07](c28fd07))


### Bug Fixes

* **filter:** Fix small bug in rename filter
([#164](#164))
([8fb7158](8fb7158))
* Rename filter metadata handling
([#165](#165))
([eb16768](eb16768))
* Replace assert with warning
([#157](#157))
([ca55a62](ca55a62))


### Documentation

* Filter documentation review
([#172](#172))
([c606ed6](c606ed6))
* Revisit documentation of filters
([#169](#169))
([2657b13](2657b13))

---
> [!IMPORTANT]
> Please do not change the PR title, manifest file, or any other
automatically generated content in this PR unless you understand the
implications. Changes here can break the release process.
> ⚠️ Merging this PR will:
> - Create a new release
> - Trigger deployment pipelines
> - Update package versions

 **Before merging:**
 - Ensure all tests pass
 - Review the changelog carefully
 - Get required approvals

[Release-please
documentation](https://github.com/googleapis/release-please)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants