Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@anaprietonem
Copy link
Contributor

Description

What problem does this change solve?

What issue or task does this change relate to?

Additional notes

As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/

@github-actions github-actions bot added the tests label May 30, 2025
@anaprietonem
Copy link
Contributor Author

@mpvginde @aaron-hopkinson this is the branch where I have kept working on the q_to_r_height filter. So far what I have added is the backward transform and a start of the testing based on the same inputs/outputs used for this filter in anemoi-datasets. The tests are still work in progress because:

  • to test this filter we would need a new release of earthkit-meteo and also a fix of https://github.com/ecmwf/earthkit-meteo/blob/develop/src/earthkit/meteo/vertical/array/vertical.py relative_geopotential_thickness to use the right import from 'thermo'. I have contacted Sandor about this
  • so far when running the test - the forward transform fails in the GroupByParam because there is a mismatch between the group and the params. Hypothesis could be the matching is not working well with inputs that contain both sfc and pl (or ml) variables. This needs further looking

@anaprietonem anaprietonem marked this pull request as ready for review June 4, 2025 11:27
@anaprietonem anaprietonem merged commit 05f401c into feat/thermo_conversions_height Jun 4, 2025
55 of 68 checks passed
@anaprietonem anaprietonem deleted the feat/thermo_conversions_height_backward_and_test branch June 4, 2025 11:28
mpvginde added a commit that referenced this pull request Jul 1, 2025
<!-- What issue or task does this change relate to? -->

<!-- Describe if it's a bugfix, new feature, doc update, or breaking
change -->

<!-- link to Issue Number -->

<!-- Include any additional information, caveats, or considerations that
the reviewer should be aware of. -->

***As a contributor to the Anemoi framework, please ensure that your
changes include unit tests, updates to any affected dependencies and
documentation, and have been tested in a parallel setting (i.e., with
multiple GPUs). As a reviewer, you are also responsible for verifying
these aspects and requesting changes if they are not adequately
addressed. For guidelines about those please refer to
https://anemoi.readthedocs.io/en/latest/***

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
mpvginde pushed a commit that referenced this pull request Jul 1, 2025
<!-- What issue or task does this change relate to? -->

<!-- Describe if it's a bugfix, new feature, doc update, or breaking
change -->

<!-- link to Issue Number -->

<!-- Include any additional information, caveats, or considerations that
the reviewer should be aware of. -->

***As a contributor to the Anemoi framework, please ensure that your
changes include unit tests, updates to any affected dependencies and
documentation, and have been tested in a parallel setting (i.e., with
multiple GPUs). As a reviewer, you are also responsible for verifying
these aspects and requesting changes if they are not adequately
addressed. For guidelines about those please refer to
https://anemoi.readthedocs.io/en/latest/***

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
aaron-hopkinson pushed a commit that referenced this pull request Jul 10, 2025
## Description
<!-- What issue or task does this change relate to? -->

## What problem does this change solve?
<!-- Describe if it's a bugfix, new feature, doc update, or breaking
change -->

## What issue or task does this change relate to?
<!-- link to Issue Number -->

##  Additional notes ##
<!-- Include any additional information, caveats, or considerations that
the reviewer should be aware of. -->

***As a contributor to the Anemoi framework, please ensure that your
changes include unit tests, updates to any affected dependencies and
documentation, and have been tested in a parallel setting (i.e., with
multiple GPUs). As a reviewer, you are also responsible for verifying
these aspects and requesting changes if they are not adequately
addressed. For guidelines about those please refer to
https://anemoi.readthedocs.io/en/latest/***

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
aaron-hopkinson pushed a commit that referenced this pull request Jul 10, 2025
<!-- What issue or task does this change relate to? -->

<!-- Describe if it's a bugfix, new feature, doc update, or breaking
change -->

<!-- link to Issue Number -->

<!-- Include any additional information, caveats, or considerations that
the reviewer should be aware of. -->

***As a contributor to the Anemoi framework, please ensure that your
changes include unit tests, updates to any affected dependencies and
documentation, and have been tested in a parallel setting (i.e., with
multiple GPUs). As a reviewer, you are also responsible for verifying
these aspects and requesting changes if they are not adequately
addressed. For guidelines about those please refer to
https://anemoi.readthedocs.io/en/latest/***

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
aaron-hopkinson pushed a commit that referenced this pull request Jul 14, 2025
## Description
<!-- What issue or task does this change relate to? -->

## What problem does this change solve?
<!-- Describe if it's a bugfix, new feature, doc update, or breaking
change -->

## What issue or task does this change relate to?
<!-- link to Issue Number -->

##  Additional notes ##
<!-- Include any additional information, caveats, or considerations that
the reviewer should be aware of. -->

***As a contributor to the Anemoi framework, please ensure that your
changes include unit tests, updates to any affected dependencies and
documentation, and have been tested in a parallel setting (i.e., with
multiple GPUs). As a reviewer, you are also responsible for verifying
these aspects and requesting changes if they are not adequately
addressed. For guidelines about those please refer to
https://anemoi.readthedocs.io/en/latest/***

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
aaron-hopkinson pushed a commit that referenced this pull request Jul 14, 2025
<!-- What issue or task does this change relate to? -->

<!-- Describe if it's a bugfix, new feature, doc update, or breaking
change -->

<!-- link to Issue Number -->

<!-- Include any additional information, caveats, or considerations that
the reviewer should be aware of. -->

***As a contributor to the Anemoi framework, please ensure that your
changes include unit tests, updates to any affected dependencies and
documentation, and have been tested in a parallel setting (i.e., with
multiple GPUs). As a reviewer, you are also responsible for verifying
these aspects and requesting changes if they are not adequately
addressed. For guidelines about those please refer to
https://anemoi.readthedocs.io/en/latest/***

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
aaron-hopkinson pushed a commit that referenced this pull request Jul 23, 2025
## Description
<!-- What issue or task does this change relate to? -->

## What problem does this change solve?
<!-- Describe if it's a bugfix, new feature, doc update, or breaking
change -->

## What issue or task does this change relate to?
<!-- link to Issue Number -->

##  Additional notes ##
<!-- Include any additional information, caveats, or considerations that
the reviewer should be aware of. -->

***As a contributor to the Anemoi framework, please ensure that your
changes include unit tests, updates to any affected dependencies and
documentation, and have been tested in a parallel setting (i.e., with
multiple GPUs). As a reviewer, you are also responsible for verifying
these aspects and requesting changes if they are not adequately
addressed. For guidelines about those please refer to
https://anemoi.readthedocs.io/en/latest/***

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
aaron-hopkinson pushed a commit that referenced this pull request Jul 23, 2025
<!-- What issue or task does this change relate to? -->

<!-- Describe if it's a bugfix, new feature, doc update, or breaking
change -->

<!-- link to Issue Number -->

<!-- Include any additional information, caveats, or considerations that
the reviewer should be aware of. -->

***As a contributor to the Anemoi framework, please ensure that your
changes include unit tests, updates to any affected dependencies and
documentation, and have been tested in a parallel setting (i.e., with
multiple GPUs). As a reviewer, you are also responsible for verifying
these aspects and requesting changes if they are not adequately
addressed. For guidelines about those please refer to
https://anemoi.readthedocs.io/en/latest/***

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants