fix: remove variable from xarray metadata when grouping #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-hopkinson
approved these changes
Oct 30, 2025
aaron-hopkinson
pushed a commit
that referenced
this pull request
Oct 31, 2025
🤖 Automated Release PR This PR was created by `release-please` to prepare the next release. Once merged: 1. A new version tag will be created 2. A GitHub release will be published 3. The changelog will be updated Changes to be included in the next release: --- ## [0.1.18](0.1.17...0.1.18) (2025-10-30) ### Features * Add AccumToInterval filter transform ([#168](#168)) ([0801a4b](0801a4b)) * Generic cos sin from rad filter ([#180](#180)) ([7fabff9](7fabff9)) ### Bug Fixes * Clarify error message ([#181](#181)) ([1cd0536](1cd0536)) * Remove variable from xarray metadata when grouping ([#182](#182)) ([46465cd](46465cd)) --- > [!IMPORTANT] > Please do not change the PR title, manifest file, or any other automatically generated content in this PR unless you understand the implications. Changes here can break the release process. >⚠️ Merging this PR will: > - Create a new release > - Trigger deployment pipelines > - Update package versions **Before merging:** - Ensure all tests pass - Review the changelog carefully - Get required approvals [Release-please documentation](https://github.com/googleapis/release-please)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves an issue where xarray params are not grouped correctly.
What problem does this change solve?
XArrayMetadata contains both 'variable' and 'param' so grouping by the metadata doesn't work because GroupByParam._get_groups only takes param into account by popping it and looking at the remaining metadata. If the remaining metadata matches then the params are grouped together. This doesn't work when variable is also there, because now the remaining metadata doesn't match
What issue or task does this change relate to?
ecmwf/anemoi-datasets#456
See also discussion in ecmwf/anemoi-datasets#457
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.