Feature/zarr fdb interface todos #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/zarr-fdb-interface #186 +/- ##
==============================================================
+ Coverage 74.53% 74.57% +0.04%
==============================================================
Files 358 359 +1
Lines 20968 21070 +102
Branches 2139 2150 +11
==============================================================
+ Hits 15628 15714 +86
- Misses 5340 5356 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4819cd0 to
303b6d2
Compare
The extension axis is now only needed for a build with multiple parts. For an single part it's simply ignored.
In case the keyword is already mapped by another axis or isn't mapped by any axis, throw a eckit user error instead of std::runtime_error.
Noted the class where the exception occurred.
With the introduction of the writeInto method with he list_iterator interface the former one is now obsolete.
This is really just an interface for the Mock or the FDB wrapper and thus should be called accordingly.
04d3d91 to
60ca37b
Compare
60ca37b to
6145207
Compare
This test case checks for permuted order in the MARS request, as well as in the AxisDefinition.
Added test cases for chunked and non-chunked permutations of axis, in the MARS requests, as well as in the AxisDefinitons. Added further comments to the test cases.
Ozaq
reviewed
Oct 29, 2025
Comment on lines
47
to
49
| if (viewParts.empty()) { | ||
| throw eckit::UserError("ChunkedDataViewBuilder: No view parts are given."); | ||
| } |
Ozaq
reviewed
Oct 29, 2025
src/chunked_data_view/ViewPart.cc
Outdated
Comment on lines
106
to
107
| // @info This is not checking whether the parameters are matching, in theory we could | ||
| // stitch mismatching parameters. |
Contributor
There was a problem hiding this comment.
This comment is misleading, we do not care for the parameters, the only thing that needs to match is the field size / field data type. If we have Surface fields on one side and Pressure layer on the other we already stitch different parameters and that's intentional.
Contributor
Author
There was a problem hiding this comment.
This is exactly what the comment is aiming for the possibility of merging different 'cubes' . How is this misleading?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing the open todos in the new codebase.
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation Z3FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/z3fdb/pull-requests/PR-186
🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-186