POSIX compatibility #147
Merged
POSIX compatibility #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thought I'd fix it in my fork, then create a pull-request, and looky there, there it is already waiting 8 months. I wish this was already merged when I was fighting with |
and is the default shell for the build user. See #143
Since there is a separate error message now if not, not so much more details need to be explained there any more.
c23040e to
b473f64
Compare
|
@lattenwald sorry about that, I'll merge this now and we'll see to cut a new release soon. |
|
This is causing an issue as reported in #263 Specifically this line: https://github.com/edeliver/edeliver/blob/master/libexec/erlang#L312 |
|
@nulian can you submit a patch please? |
|
I just reverted it for me to make it work. I'm not sure what is truly valid in POSIX because of not having a lot of knowledge about that. Found out this mostly with trial and error. |
|
It works correctly from master now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all shell scripts on deploy hosts POSIX compatible. This allows to use there any shell as default shell (instead of requiring bash or zsh). Closes #143.