Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix wrong usage of xorm #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2022
Merged

Fix wrong usage of xorm #2

merged 1 commit into from
Apr 22, 2022

Conversation

@lunny
Copy link
Contributor

@lunny lunny commented Apr 22, 2022

For xorm, some usage is wrong.

  • Update should have a condition, otherwise it will update all the records
  • Read should use id as condition to get one record from database and disable automatically conditions from the struct.

@efectn efectn merged commit c9678ec into efectn:master Apr 22, 2022
@lunny lunny deleted the lunny/fix_xorm_update branch April 22, 2022 16:31
@efectn
Copy link
Owner

efectn commented Apr 22, 2022

Hi @lunny. XORM gives ID condition is error, expect 0 primarykeys, there are 1 after this changes. Can you check it? Thanks

@lunny lunny mentioned this pull request Apr 23, 2022
Merged
@lunny
Copy link
Contributor Author

lunny commented Apr 23, 2022

Hi @lunny. XORM gives ID condition is error, expect 0 primarykeys, there are 1 after this changes. Can you check it? Thanks

I have sent #3 to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lunny @efectn