Reviewing files that changed from the base of the PR and between b3d83d8 and 191ddf5.

• package.json (1 hunks)
• src/app/extend/application.ts (8 hunks)
• src/app/middleware/cluster_app_mock.ts (1 hunks)
• test/fixtures/tegg-app-esm/test/hooks.test.ts (2 hunks)
• test/fixtures/tegg-app-esm/test/tegg_context.test.ts (1 hunks)
• test/fixtures/tegg-app/test/hooks.test.ts (2 hunks)
• test/fixtures/tegg-app/test/tegg_context.test.ts (1 hunks)
• test/index.test-d.ts (1 hunks)

src/app/extend/application.ts (11)

9-10: Use consistent import naming.

Replacing Logger with EggLogger and ContextDelegation with Context is consistent with the new implementation. Confirm that all other imports referencing ContextDelegation are removed or updated throughout the codebase.

---

42-42: Interface rename is clear and aligns with Egg’s standard context.

Changing MockContextDelegation to MockContext and extending Context ensures better type checking and clarity. Keep an eye out for any references to the old interface name.

---

50-52: Logger type alignment.

These changes ensure that the application’s logger and coreLogger properties match Egg’s official logger type. This should help avoid confusion and leverage the proper Egg logger APIs.

---

76-76: Transition from MockContextDelegation to MockContext in return type.

Returning MockContext here aligns with the new extended interface and enhances type consistency.

---

105-105: Reusing existing currentContext.

Ensuring the returned context is properly cast to MockContext. This is acceptable as long as the underlying currentContext truly conforms to MockContext.

---

112-112: Directly returning the new context.

Casting the newly created context to MockContext is consistent. Just verify all relevant properties are initialized properly (e.g., service).

---

115-115: Method signature update to accept and return MockContext.

Using MockContext clarifies what context methods or properties can be used within the scope function. The async logic here remains clear.

---

407-407: Logger parameter usage.

The update to EggLogger clarifies usage and ensures the parameter can accept a logger instance conforming to Egg’s standard. No further changes needed.

---

427-427: Synchronized logger checks with EggLogger.

Ensures _mockLogs logic works properly with the updated logger type. This method’s approach to reading logs from memory or file remains valid.

---

463-463: expectLog method aligned with EggLogger.

Maintains consistency with the rest of the logger changes in the file. Good job.

---

473-473: notExpectLog method aligned with EggLogger.

Ensures consistency with new logging approach. No issues noted.

test/fixtures/tegg-app/test/tegg_context.test.ts (2)

2-2: Context import alignment.

This change from ContextDelegation to Context is in line with the broader context refactor. Confirm no references to the old type remain.

---

8-8: Context variable declaration.

Declaring ctx with the new Context type ensures type safety. Looks good.

test/fixtures/tegg-app-esm/test/tegg_context.test.ts (2)

2-2: Update to import from egg.

Renaming to Context is correct and consistent with Egg framework updates.

---

8-8: Variable type updated.

Switching ctx to the Context type aligns with the rest of the PR’s context changes.

test/fixtures/tegg-app-esm/test/hooks.test.ts (5)

2-2: Import Context from egg.

Good replacement of the old ContextDelegation type. Ensures that the test suite references the correct context type.

---

9-11: Variables updated to Record<string, Context>.

Switching the type from a custom delegation to the standard Egg Context clarifies usage. Keep an eye on any helper methods that might expect the old type.

---

29-37: Assigning app.currentContext to typed objects.

Casting app.currentContext as Context ensures type safety in tests. No issues found.

---

43-51: Same pattern for bar suite.

Behavior is identical to the foo suite, which is consistent and good.

---

56-63: Array of Context objects in multi-it tests.

Appending multiple Context references ensures each test run is self-contained. This approach is valid.

test/fixtures/tegg-app/test/hooks.test.ts (5)

2-2: Import Context from egg.

Updating the import to use Context matches the removal of ContextDelegation from the codebase.

---

9-11: Initialization of context dictionaries with Context.

Switches to Context confirm the new type is fully adopted.

---

29-37: Ensuring typed references to currentContext.

Consistently casting to Context ensures no untyped usage.

---

43-51: bar suite updated for type consistency.

Matches the foo suite approach.

---

56-63: Storing multiple contexts in an array.

Confirming the array is typed as Array<Context>. Consistency is maintained here as well.

test/index.test-d.ts (2)

2-2: Consider removing unused references to ContextDelegation.
Great job replacing ContextDelegation with Context. If there are any remaining references to ContextDelegation in other files or test cases, consider removing them for consistency.

---

8-9: Verify correctness of type assertions.
Using Context | undefined ensures stricter type safety. Just confirm you have test coverage to validate these scenarios (when app.currentContext or app.ctxStorage.getStore() might be undefined).

src/app/middleware/cluster_app_mock.ts (2)

2-2: Context type alignment.
Updating ContextDelegation to Context is consistent with the new Egg.js definitions. Good job making this change.

---

7-7: Preserve functionality after type replacement.
Be sure that no ContextDelegation-specific properties or methods are being relied on. Confirm that any references to older context properties are updated accordingly.

package.json (1)

32-32: Verify compatibility with @eggjs/core@^6.2.11.
Ensure that other dependencies and your code are fully compatible with the updated @eggjs/core version.