feat: first version #1

gxcsoccer · 2016-07-15T17:04:21Z

迁移
删除对复数目录的兼容
删除 antx 逻辑（用 appInfo { name, baseDir, env, HOME, pkg } 代替）
删除一些兼容逻辑，例如：customEgg

gxcsoccer · 2016-07-15T17:14:44Z

cc: @popomore

atian25 · 2016-07-15T17:21:15Z

README.md

ok, 漏掉了

fengmk2 · 2016-07-15T17:22:32Z

app.name 可以删除了, appname 改为 name ?

atian25 · 2016-07-15T17:24:52Z

lib/base_loader.js

这行不需要了吧？

测试可能重复加载

atian25 · 2016-07-15T17:32:06Z

lib/base_loader.js

这个命名感觉有点疑惑，getLoadDirs？

这个已经很多地方在用了，重构的时候再考虑 api 吧

做个别名兼容吧，loader内部使用换名字

这个可能会改

fengmk2 · 2016-07-15T17:38:43Z

README.md

atian25 · 2016-07-15T17:54:11Z

lib/plugin_loader.js

这里会覆盖插件的eggPlugin么？

是的，这里还少了 eggPlugin

atian25 · 2016-07-15T18:01:13Z

lib/plugin_loader.js

用 framework 代替？

atian25 · 2016-07-15T18:07:10Z

package.json

不叫mm了吧？

egg-mock ? 先 mm 了，后面换吧

close eggjs/egg#11

gxcsoccer · 2016-07-15T18:25:00Z

+ [email protected]

popomore · 2016-07-29T07:36:31Z

lib/base_loader.js

+  loadFrameworkPaths() {
+    const eggPath = this.eggPath;
+    const frameworkPaths = [];
+


这里 customEgg 怎么没了

```bash egg start timeline: ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [289ms] - #0 Process Start ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [510ms] - #1 Application Start ▇ [2ms] - #2 Load Plugin ▇ [1ms] - #3 Load Config ▇ [0ms] - #4 Require(0) ~/eggjs/egg-core/test/fixtures/egg/config/config.default.js ▇ [0ms] - #5 Require(1) ~/eggjs/egg-core/test/fixtures/egg/config/config.unittest.js ▇ [0ms] - #6 Load extend/application.js ▇ [0ms] - #7 Require(2) ~/eggjs/egg-core/test/fixtures/egg/app/extend/application.js ▇ [1ms] - #8 Load extend/context.js ▇ [0ms] - #9 Load extend/request.js ▇ [0ms] - #10 Load extend/response.js ▇ [1ms] - #11 Load app.js ▇ [0ms] - #12 Require(3) ~/eggjs/egg-core/test/fixtures/egg/node_modules/session/app.js ▇ [0ms] - #13 Require(4) app.js ▇▇▇▇▇▇ [101ms] - #14 readyCallback in a ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [501ms] - #15 readyCallback in b ▇ [4ms] - #16 Load Middleware ▇ [4ms] - #17 Load "middlewares" to Application ▇ [2ms] - #18 Load Service ▇ [2ms] - #19 Load "service" to Context ▇ [0ms] - #20 Load Controller ▇ [0ms] - #21 Load "controller" to Application ▇ [0ms] - #22 Load Router ```

[skip ci] ## [5.3.0](v5.2.0...v5.3.0) (2023-01-13) ### Features * support show app.timing in timline string ([#260](#260)) ([5b7af12](5b7af12)), closes [#0](https://github.com/eggjs/egg-core/issues/0) [#1](#1) [#2](#2) [#3](#3) [#4](#4) [#5](#5) [#6](#6) [#7](#7) [#8](#8) [#9](#9) [#10](#10) [#11](#11) [#12](#12) [#13](#13) [#14](#14) [#15](#15) [#16](#16) [#17](#17) [#18](#18) [#19](#19) [#20](#20) [#21](#21) [#22](#22)

gxcsoccer force-pushed the first-version branch from b31c986 to 98210e9 Compare July 15, 2016 17:09

gxcsoccer assigned fengmk2 Jul 15, 2016

atian25 reviewed Jul 15, 2016
View reviewed changes

gxcsoccer force-pushed the first-version branch from 455057e to dbcc7b5 Compare July 15, 2016 17:30

atian25 reviewed Jul 15, 2016
View reviewed changes

gxcsoccer force-pushed the first-version branch from 1b9fe8a to 69b12b8 Compare July 15, 2016 17:36

fengmk2 reviewed Jul 15, 2016
View reviewed changes

README.md Outdated

Copy link

Member

fengmk2 Jul 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

,

gxcsoccer force-pushed the first-version branch from 877407e to 1e35d30 Compare July 15, 2016 17:51

atian25 reviewed Jul 15, 2016
View reviewed changes

lib/plugin_loader.js Outdated

Copy link

Member

atian25 Jul 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用 framework 代替？

gxcsoccer force-pushed the first-version branch from 80926d3 to 4905ef8 Compare July 15, 2016 18:06

atian25 reviewed Jul 15, 2016
View reviewed changes

feat: first version

0465b10

close eggjs/egg#11

gxcsoccer force-pushed the first-version branch from 1e5db76 to 0465b10 Compare July 15, 2016 18:15

gxcsoccer merged commit d0a4632 into master Jul 15, 2016

gxcsoccer deleted the first-version branch July 15, 2016 18:19

popomore reviewed Jul 29, 2016
View reviewed changes

lib/base_loader.js

loadFrameworkPaths() {

const eggPath = this.eggPath;

const frameworkPaths = [];

Copy link

Member

popomore Jul 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 customEgg 怎么没了

feat: first version #1

feat: first version #1

Uh oh!

Conversation

gxcsoccer commented Jul 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gxcsoccer commented Jul 15, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fengmk2 commented Jul 15, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gxcsoccer commented Jul 15, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gxcsoccer commented Jul 15, 2016 •

edited

Loading