Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@fengmk2
Copy link
Member

@fengmk2 fengmk2 commented May 10, 2017

No description provided.

@mention-bot
Copy link

@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @popomore, @dead-horse and @atian25 to be potential reviewers.

* Documents improved. Thanks @Rwing, @lslxdx, @solarhell, @magicdawn
* API document is out https://eggjs.org/api/
* **refactor**
* Set coreLogger's consoleLevel to WARN in local env
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@popomore 还是得发个版本,要不然这个日志一直在

* [[`e55a134`](http://github.com/eggjs/egg/commit/e55a13439ec297081d33a7eb2f87ece605581908)] - docs: Add a link to issue template (#853) (Haoliang Gao <<[email protected]>>)
* [[`b01d30e`](http://github.com/eggjs/egg/commit/b01d30e33e9b910ee24d69d3b55e2dbe887ff4e3)] - docs: Fix typo. (#869) (jethro <<[email protected]>>)
* [[`b3403b5`](http://github.com/eggjs/egg/commit/b3403b56a5635394a4dc9825ef2780850449e573)] - docs: fix view typo (#867) (Tao <<[email protected]>>)
* [[`5d6e067`](http://github.com/eggjs/egg/commit/5d6e067fc36697b7c01f290bccac06ce21fb4371)] - chore: add quality badge (#857) (仙森 <<[email protected]>>)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okoala 请将你的邮箱和 name 都改成 github 的

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我检查下

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么是 <<>> ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

里面那个是给邮箱加链接

@popomore
Copy link
Member

#888 修复了合并

@fengmk2
Copy link
Member Author

fengmk2 commented May 11, 2017

等 ci pass

@codecov
Copy link

codecov bot commented May 11, 2017

Codecov Report

Merging #885 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #885   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          28     28           
  Lines         667    667           
=====================================
  Hits          667    667

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6681a...6ecdbd2. Read the comment docs.

@popomore popomore merged commit e13c515 into master May 11, 2017
@popomore popomore deleted the release-1.3 branch May 11, 2017 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants