Very small bug fix in Wavefront class #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
=======================================
Coverage 80.70% 80.70%
=======================================
Files 95 95
Lines 7044 7044
=======================================
Hits 5685 5685
Misses 1359 1359
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ehpor
approved these changes
Nov 23, 2022
|
probably because nobody uses wavenumbers. at least I know I never use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a code breaking typo in the Wavefront class. The wavenumber assignment method used npf.pi instead of np.pi. I fixed this.