replace asdf.fits_embed #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like there are some problems with files still being open after the write function has returned, but only on Windows. |
|
As discussed offline with Brett, the failing tests are likely caused by memmap handling changes between Windows and Linux/Mac. I'll try to fix this since the changes are most likely easy to fix, plus easy to combine with reviewing. If they are difficult to resolve, the ball is back in Brett's court. |
|
@braingram I don't know why codecov reports are not coming through to the Github check, but it's positive diff coverage, so I'm fine with force merging. Everything is working now as well. |
|
Force merging since codecov didn't forward its check to Github Checks for some reason. See comment above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asdf 3.0 removed the deprecated
AsdfInFits(andasdf.fits_embed) used here to read/write fits files (see https://asdf.readthedocs.io/en/3.0.1/asdf/whats_new.html#whats-new-3-0-0 for descriptions of other changes).This PR replaces uses of
asdf.fits_embedwith equivalent code. This was tested locally by modifying:To save all test files (and not remove them after the test passed). Test files were generated with hcipy main and asdf 2.15.2 (we'll call these 'old' files) and with hcipy using this PR and asdf 3.0.1 ('new' files). hcipy main with asdf 2.15.2 could read both new and old files as could hcipy with this PR and asdf 3.0.1.
If there are static files that aren't captured by these tests it would be helpful to test those files with this PR to verify that the updated code can open all files generated with older versions of hcipy.