Fix CI regression and update Python version support #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
==========================================
- Coverage 82.21% 82.05% -0.16%
==========================================
Files 102 102
Lines 7555 7556 +1
==========================================
- Hits 6211 6200 -11
- Misses 1344 1356 +12 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing on macos-latest now uses Apple M1 chips, so runs on ARM. The required package mkl_fft is not available on ARM. This PR makes mkl_fft an optional dependency for testing.
The distributed FFMpeg of conda now no longer supports the preset argument for some reason. This PR makes the preset argument optional.
This PR also removes support for Python 3.7 & Python 3.8, and adds support for Python 3.12.