Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ehpor
Copy link
Owner

@ehpor ehpor commented Nov 20, 2024

Smaller tests make parallel execution of tests faster. Also, it enables better output when the tests fail.

Using tmpdir for file output also enables running tests in parallel.

@ehpor ehpor requested a review from raphaelpclt November 20, 2024 00:03
@ehpor ehpor self-assigned this Nov 20, 2024
@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.06%. Comparing base (6d53970) to head (a5ef5bd).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #244   +/-   ##
=======================================
  Coverage   82.06%   82.06%           
=======================================
  Files         104      104           
  Lines        7626     7626           
=======================================
  Hits         6258     6258           
  Misses       1368     1368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehpor ehpor requested review from dsdoelman and removed request for raphaelpclt November 20, 2024 06:34
@ehpor ehpor force-pushed the feature/smaller_tests_and_tempdir branch from 2418159 to a214398 Compare November 21, 2024 18:48
@ehpor ehpor added the maintenance Non-critical, but may become an issue in the future. label Nov 21, 2024
@ehpor ehpor force-pushed the feature/smaller_tests_and_tempdir branch from a214398 to c0e0ab3 Compare November 27, 2024 17:54
@ehpor ehpor requested a review from syhaffert December 13, 2024 21:12
Copy link
Collaborator

@syhaffert syhaffert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. And the tests still correctly run according to the github pytest results. So I would say ready for merging.

@ehpor ehpor force-pushed the feature/smaller_tests_and_tempdir branch from c0e0ab3 to a5ef5bd Compare December 16, 2024 17:40
@ehpor ehpor enabled auto-merge December 16, 2024 17:40
@ehpor ehpor merged commit 2a454a0 into master Dec 16, 2024
16 checks passed
@ehpor ehpor deleted the feature/smaller_tests_and_tempdir branch December 16, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Non-critical, but may become an issue in the future.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants