From in-person conversation with Emiel

• add CAD/drawing for pupils
• double check pupils match drawing
• add plots to pupil tutorial

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.93%. Comparing base (eaebf7d) to head (1f80f52).
Report is 12 commits behind head on master.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   84.82%   84.93%   +0.10%     
==========================================
  Files         104      104              
  Lines        8008     8057      +49     
==========================================
+ Hits         6793     6843      +50     
+ Misses       1215     1214       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Test failures are not due to this PR. Fixing in #246 and #245.

• Rebased onto master. Fixed merge conflicts.
• Fixed formatting of docstrings.
• Squashed adding the reference pupils into a single commit to reduce the size of the hcipy repository.
• Fixed existing flake8 errors.

@mileslucas Only waiting on a picture of a CAD drawing of the pupil and the HCIPy pupil fits file in DS9 next to it. Otherwise this is fully ready to go. If you're not allowed to share that, or if that's too much to ask, or if that's difficult (read: >5mins of work) to look up, then I'm fine with merging without that confirmation.

Thanks, we got some drawings made for the pupils--for now just on Google Drive. I'll get the references checked and try and close this out next week.

Okay, here is a reference for the SCExAO pupil mask: https://drive.google.com/file/d/1WddQr1quYshpPvvIbGt3hRzdmHnb4gT1/view?usp=drive_link

Here is a matplotlib figure generated via

import hcipy as hp
import matplotlib.pyplot as plt

pupil_grid = hp.make_pupil_grid(256, diameter=1)
aper = hp.make_scexao_aperture(normalized=True)
pupil = hp.Wavefront(hp.evaluate_supersampled(aper, pupil_grid, 8))
hp.plotting.imshow_pupil_phase(aper)

plt.savefig("test_pupil.pdf")

overlaid with 50% opacity on the mask CAD drawing.

Thanks Emiel! I dragged my feet a bit and I appreciate you carrying this over the finish line.