[pull] release/2025.1 from metalama:release/2025.1 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.GetAspectInstancesAsync when aspect instance has successors
…ckport Topic/2025.1/1183 aspect db backport
…e parameters Reproduces the bug where RemoveReferenceNullableAnnotationsRewriterForSymbol throws InvalidCastException when processing T? inside a generic type like List<T?> where T is an unconstrained type parameter. --Claude
Tests the IType path with an introduced method returning List<T?>. --Claude
…nsRewriter When processing T? where T is an unconstrained type parameter, the rewriter incorrectly assumed it was Nullable<T> and tried to cast to INamedTypeSymbol. Added check for ITypeParameterSymbol/ITypeParameter before the cast. Also removed unnecessary #nullable enable from test files. --Claude
Tests various scenarios with nullable type parameters: - T? directly (not inside another generic) - T?[] array - (T?, string) tuple - Dictionary<string, List<T?>> nested generics --Claude
Fix #1231: InvalidCastException with nullable type parameters in typeof
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? đź’– Please sponsor : )