perf(test): improve timeout for test cases #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeout values added for test cases from environment variables. Fixes issue eicrud#100.
acrosett
reviewed
Nov 11, 2024
There was a problem hiding this comment.
TEST_TIMEOUT should be at least 6000, here, in action-test.yml and in the .env.sample
There was a problem hiding this comment.
this seems to be in the wrong place, here it is attached to the mongo service
Default timeout value updated.
Fixes issue eicrud#100.
acrosett
requested changes
Nov 11, 2024
There was a problem hiding this comment.
added a few more comments,
ideally we could make use of the setup.js mentioned in this issue so that we can set the default timeout for all tests and ditch the "testTimeout" in package.json. However we can already merge this if you want
There was a problem hiding this comment.
this seems to be in the wrong place, here it is attached to the mongo service
env.ts added for better variables management.
Fixes issue eicrud#100.
acrosett
requested changes
Nov 12, 2024
acrosett
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeout values added for test cases from environment variables.
Fixes issue #100.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information