feat: add configuration flag to support maximum retries on resource failure #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maplebed
commented
Oct 8, 2025
| } | ||
|
|
||
| if e.Caller.Line == 351 { | ||
| if e.Caller.Line == 352 { |
Contributor
Author
There was a problem hiding this comment.
By adding the new parameter, it changed the line that is triggered in this test.
maplebed
commented
Oct 8, 2025
| ForceSleep: 3, | ||
| Quiet: true, | ||
| NoDryRun: true, | ||
| MaxFailureRetries: 6, |
Contributor
Author
There was a problem hiding this comment.
choosing a non-default number of retries here to ensure the option is honored.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=======================================
Coverage 99.32% 99.32%
=======================================
Files 20 20
Lines 1782 1785 +3
=======================================
+ Hits 1770 1773 +3
Misses 9 9
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
can you fix the last commit to be |
a4b265b to
0e60b79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configuration parameter that controls the number of times to retry when no work remains but failed dependencies. Increasing this from the previous default of
3can help when some resources need more time between being deleted and other resources that depend upon them being eligible for deletion.Fixes: ekristen/aws-nuke#760