Add embed url to share button #1617
Open
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was requested to supply an easy way to get the embed url without having to manually copy it from the iframe. In order to not blow up the vertical space needed by the menu, I shrunk the <iframe> copy thingy a bit, which should be fine. It was larger because that would make it easier to get to the url in the first place (I think). It's still scrollable. This is just an admittedly low-effort proposition, but I'm not sure if there is or needs to be a nicer way.
Collaborator
|
Thanks, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was requested to supply an easy way to get the embed url without having to manually copy it from the iframe code.
So this adds a second "copyable input" line to the embed tab of the share menu.
In order to not blow up the vertical space needed by the menu, I shrunk the <iframe> copy thing a bit, which should be fine. It was larger because that would make it easier to get to the url in the first place (I think). It's still scrollable.
This is just a(n admittedly low-effort) proposition, but I'm not sure if there is or needs to be a nicer way.
Closes #1597