Cherry-pick #6346 to 6.2: Filebeat in memory states registry improvements #6804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Filebeat in memory states registry improvements - make States type easier to find by moving into separate states.go file - Ensure provides States constructor is actually used - Add ID->array index, index for faster lookups on update and find operations. When updating states in a big registry, the Updates converged to quadratic complexity. The index helps in keeping the complexity about linear in number of state updates. - Debug will print number of states subject to future cleanups (if state TTL > 0) - Add title to states unit tests * Fix godocs * update state index in Cleanup * Refine index handling + reintroduce debug message * review (cherry picked from commit 490cbcd)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ic#6804) * Filebeat in memory states registry improvements - make States type easier to find by moving into separate states.go file - Ensure provides States constructor is actually used - Add ID->array index, index for faster lookups on update and find operations. When updating states in a big registry, the Updates converged to quadratic complexity. The index helps in keeping the complexity about linear in number of state updates. - Debug will print number of states subject to future cleanups (if state TTL > 0) - Add title to states unit tests * Fix godocs * update state index in Cleanup * Refine index handling + reintroduce debug message * review (cherry picked from commit 042b284)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #6346 to 6.2 branch. Original message:
operations. When updating states in a big registry, the Updates
converged to quadratic complexity. The index helps in keeping the
complexity about linear in number of state updates.