This repository was archived by the owner on Mar 5, 2024. It is now read-only.
Add option to ignore hidden values #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently assertEqualsModel checks hiddel values. That's bad when I want to test the output from a resource where hidden attributes will not be sent.
Contributor
|
Ich würde das ganze wahrscheinlich gar nicht steuerbar machen. Hidden values sind in den meisten Fällen sowieso gehasht oder encrypted. Also sowieso nicht wirklich über einen simples string Vergleich miteinander vergleichbar. Wenn ich also den Bedarf habe diese zu vergleichen - z.B. bei den Recovery Codes dann muss sehr wahrscheinlich ein check à la |
…om:elbgoods/ci-test-tools into feature/disable_consider_hidden_attributes
Gummibeer
reviewed
Aug 4, 2020
Gummibeer
reviewed
Aug 4, 2020
Gummibeer
reviewed
Aug 4, 2020
Gummibeer
approved these changes
Aug 4, 2020
mstaack
approved these changes
Aug 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently assertEqualsModel checks hidden values. That's bad when I want to test the output from a resource where hidden attributes will not be sent.