Gtk.StyleContext, Gtk.StyleClass avoid and replace where possible #2552
Conversation
|
Some of these changes could be done in Gtk3? |
| // info_bar.get_content_area ().add (info_label); | ||
|
|
||
| info_bar.add_css_class (Granite.STYLE_CLASS_FRAME); | ||
| // info_bar.get_content_area ()add (info_label); |
There was a problem hiding this comment.
There's a commented out code here.
| notify["scale-factor"].connect (() => { | ||
| breadcrumb_icons.scale = scale_factor; | ||
| }); | ||
| // notify["scale-factor"].connect (() => { |
There was a problem hiding this comment.
There's a commented out code here.
| weak Gtk.StyleContext style_context = get_style_context (); | ||
| // var padding = style_context.get_padding (style_context.get_state ()); | ||
| // w += (l - 1) * (MINIMUM_BREADCRUMB_WIDTH + padding.left + padding.right); | ||
| w += (l - 1) * (MINIMUM_BREADCRUMB_WIDTH); |
There was a problem hiding this comment.
The commented-out code was summing two padding values. Is it okay that we’re no longer doing that?
| if (breadcrumb_icons.scale != scale) { | ||
| breadcrumb_icons.scale = scale; | ||
| int scale = get_scale_factor (); | ||
| // if (breadcrumb_icons.scale != scale) { |
There was a problem hiding this comment.
There's a commented out code here.
| } | ||
| set_element_icons (protocol, elements); | ||
| } | ||
| // string protocol = ""; |
There was a problem hiding this comment.
There's a commented out code here.
| if (room_for_text) { | ||
| button_context.render_layout (cr, x - width, | ||
| y_half_height - text_half_height, layout); | ||
| // button_context.render_layout (cr, x - width, |
There was a problem hiding this comment.
There's a commented out code here.
| if (room_for_text) { | ||
| button_context.render_layout (cr, x, | ||
| y_half_height - text_half_height, layout); | ||
| // button_context.render_layout (cr, x, |
There was a problem hiding this comment.
There's a commented out code here.
| if (text_is_displayed && room_for_text && x > 0) { | ||
| button_context.render_layout (cr, x + iw, | ||
| y_half_height - text_half_height, layout); | ||
| // button_context.render_layout (cr, x + iw, |
There was a problem hiding this comment.
There's a commented out code here.
| button_context.render_frame (cr, -height / 2, -height / 2, height, height); | ||
| button_context.restore (); | ||
| // button_context.save (); | ||
| // button_context.add_class ("noradius-button"); |
There was a problem hiding this comment.
There's a commented out code here.
| button_context.add_class ("noradius-button"); | ||
| button_context.render_frame (cr, -height / 2, -height / 2, height, height); | ||
| button_context.restore (); | ||
| // button_context.save (); |
There was a problem hiding this comment.
There's a commented out code here.
| } | ||
|
|
||
| button_context.restore (); | ||
| // button_context.restore (); |
There was a problem hiding this comment.
There's a commented out code here.
| context.set_scale (value); | ||
| return widget.get_scale_factor (); | ||
| } | ||
| // set { |
There was a problem hiding this comment.
There's a commented out code here.
| // var style_context = get_style_context (); | ||
| // style_context.add_provider (css_provider, Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION); | ||
| // style_context.add_class ("nohover"); | ||
| // add_css_class ("nohover"); |
There was a problem hiding this comment.
There's a commented out code here.
| // } | ||
|
|
||
| // if (Gtk.StateFlags.DIR_RTL in get_style_context ().get_state ()) { | ||
| // if (Gtk.TextDirection.RTL in get_direction ()) |
There was a problem hiding this comment.
There's a commented out code here.
| /* If folder is empty, draw the empty message in the middle of the view | ||
| * otherwise pass on event */ | ||
| var style_context = get_style_context (); | ||
| // var style_context = get_style_context (); |
There was a problem hiding this comment.
There's a commented out code here.
|
@leonardo-lemos Sorry, this should have been set to draft really. As it is being merged into an intermediate gtk4 branch it is expected that some of the gtk3 code will have been commented out temporarily as each PR is only intended to address one aspect of porting - in this case style classes. in order to make easier to review. As the Gtk3 version is still changing and the preparation phase is not finished these PRs are probably premature anyway. |
Simple avoidance/replacement of stylecontext use.
Style providers added to display instead of widgets. May need changes to css files and css names later.
Rendering will be addressed separately.