Txn relay fee additional fix for #18 #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Challenge crowdfunding - remove feature - restore TODO - use Result for chunker disprove witness
franklynot
approved these changes
Jan 15, 2025
franklynot
requested changes
Jan 15, 2025
src/chunker/disprove_execution.rs
Outdated
| // 1. if 'wrong_proof' is correct, return none | ||
| if wrong_proof.valid_proof() { | ||
| return None; | ||
| return Err(Error::Chunker(ChunkerError::WrongProof)); |
There was a problem hiding this comment.
This is a different error case than the 'wrong proof' below. This is a wrong proof being actually valid when it shouldn't be. So the name of the error should be ChunkerError::ValidProof or something like this.
There was a problem hiding this comment.
ValidProof doesn't sound like an error, so I change it to NotWrongProof
src/bridge/error.rs
Outdated
|
|
||
| #[derive(Debug)] | ||
| pub enum ChunkerError { | ||
| WrongProof, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.