Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@CorvusPrudens
Copy link
Collaborator

This PR adds support for the upcoming Petal 125B SM. The extent of testing can be observed in the new template file. Notably, I did not test the expression input (although I expect it to work without any issues).

@CorvusPrudens
Copy link
Collaborator Author

@beserge
Copy link

beserge commented Apr 28, 2022

Test Procedure

  • Flashed templates/oopsy_petal_125b_sm.maxpat
  • Swapped in the unused controls one at a time to make sure they worked.

These are all working:

  • toggle 1, 2, 3
  • fs 1, 2
  • pot 1, 2, 3, 4, 5, 6
  • relay
  • audio IO
  • led 1,2,3
  • expression

Note: led 4 and 5 are untested since they're uninstalled on my unit.

Template

I also looked over the json template real quick.
The only (extremely minor) gripe is that all of the component names other than the leds use underscores (knob_1 vs led1).
Only some of the controls have an underscoreless alias.
Ideally they'd all use an underscore by default and all have an alias without it.
An extremely minor gripe though!

Looks good to go! 🚀

@CorvusPrudens
Copy link
Collaborator Author

Yeah I modeled the names in Oopsy after the ones in the board support file, which may or may not be helpful. The non-underscored LED names also bothered me, so it's probably worth at least making an alias.

This fixes Seed 2 DFM extra pin issues.
@CorvusPrudens CorvusPrudens changed the base branch from dev to bootloader-additions February 6, 2023 17:44
@CorvusPrudens CorvusPrudens merged commit 497ae45 into electro-smith:bootloader-additions Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants