feat: add webContents.getPrintersAsync()#31023
Merged
jkleinsc merged 1 commit intoelectron:mainfrom Oct 25, 2021
Merged
Conversation
codebytere
reviewed
Sep 20, 2021
77dd7ce to
b3e2ea2
Compare
webContents.getPrintersAsync()webContents.getPrinters()
RaisinTen
commented
Sep 21, 2021
3177381 to
4d785ae
Compare
webContents.getPrinters()webContents.getPrintersAsync()
4d785ae to
deaf392
Compare
zcbenz
reviewed
Oct 11, 2021
deaf392 to
297d8a9
Compare
zcbenz
approved these changes
Oct 12, 2021
deepak1556
reviewed
Oct 12, 2021
Member
deepak1556
left a comment
There was a problem hiding this comment.
Thanks for working on this, left some additional reviews.
eabe270 to
e08e1b6
Compare
RaisinTen
commented
Oct 13, 2021
9877715 to
d2b04e4
Compare
Contributor
|
It is crashing on Windows: |
deepak1556
reviewed
Oct 15, 2021
9ebf849 to
1861134
Compare
1861134 to
5063ba8
Compare
This deprecates the synchronous and blocking `webContents.getPrinters()` function and introduces `webContents.getPrintersAsync()`, which is asynchronous and non-blocking. Signed-off-by: Darshan Sen <[email protected]>
5063ba8 to
1fe9f19
Compare
Contributor
Author
|
@zcbenz the crash has been fixed. |
webContents.getPrintersAsync()webContents.getPrintersAsync() fix ci
webContents.getPrintersAsync() fix ciwebContents.getPrintersAsync()
deepak1556
approved these changes
Oct 18, 2021
Member
|
API LGTM |
Member
|
Merging as CI failure is known flake already resolved. |
|
Release Notes Persisted
|
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 27, 2021
This deprecates the synchronous and blocking `webContents.getPrinters()` function and introduces `webContents.getPrintersAsync()`, which is asynchronous and non-blocking. Signed-off-by: Darshan Sen <[email protected]>
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 27, 2021
This deprecates the synchronous and blocking `webContents.getPrinters()` function and introduces `webContents.getPrintersAsync()`, which is asynchronous and non-blocking. Signed-off-by: Darshan Sen <[email protected]>
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
This deprecates the synchronous and blocking `webContents.getPrinters()` function and introduces `webContents.getPrintersAsync()`, which is asynchronous and non-blocking. Signed-off-by: Darshan Sen <[email protected]>
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
This deprecates the synchronous and blocking `webContents.getPrinters()` function and introduces `webContents.getPrintersAsync()`, which is asynchronous and non-blocking. Signed-off-by: Darshan Sen <[email protected]>
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
This deprecates the synchronous and blocking `webContents.getPrinters()` function and introduces `webContents.getPrintersAsync()`, which is asynchronous and non-blocking. Signed-off-by: Darshan Sen <[email protected]>
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
This deprecates the synchronous and blocking `webContents.getPrinters()` function and introduces `webContents.getPrintersAsync()`, which is asynchronous and non-blocking. Signed-off-by: Darshan Sen <[email protected]>
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This deprecates the synchronous and blocking
webContents.getPrinters()function and introduces
webContents.getPrintersAsync(), which isasynchronous and non-blocking.
Signed-off-by: Darshan Sen [email protected]
cc @deepak1556 @nornagon
Checklist
npm testpassesRelease Notes
Notes: Deprecates
webContents.getPrinters()and introduceswebContents.getPrintersAsync()